bugfix-colorpicker(Added a color picker for tiles) #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlazarKnight
approved these changes
Dec 17, 2024
|
can someone please merge this PR after reviewing |
sylvansson
reviewed
Jan 3, 2025
| import KeyboardArrowRightIcon from '@material-ui/icons/KeyboardArrowRight'; | ||
| import KeyboardArrowLeftIcon from '@material-ui/icons/KeyboardArrowLeft'; | ||
| import Select from '@material-ui/core/Select'; | ||
| import MenuItem from '@material-ui/core/MenuItem'; |
There was a problem hiding this comment.
Could you undo the changes to the indentation?
There was a problem hiding this comment.
I see there is no intendation in line 15 to 18 in the main repo
| }; | ||
|
|
||
| handleChangeComplete = color => { | ||
| const colorhex = color.hex ? color.hex : ''; |
There was a problem hiding this comment.
Is this safe?
We check whether color is truthy on line 414; I assume it's possible for it to be undefined so we could get a TypeError here. Perhaps we could move this inside the if statement or use optional chaining?
Suggested change
| const colorhex = color.hex ? color.hex : ''; | |
| const colorhex = color?.hex || ''; |
There was a problem hiding this comment.
Sure , will make this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi , I have solved the issue please do review and ping me up for any further issues , thanks !